An implementation of Euclidean Algorithm in D #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
june128
added
the
Implementation
|
Thanks for the implementation! I don't really know D too well, but would it be alright to review the code from the perspective of C? |
|
The main algorithm seems to be just like the C code. Everything seems correct according to the D style guide https://dlang.org/dstyle.html |
c252
requested changes
Mar 18, 2019
| auto check1 = euclid_mod(64 * 67, 64 * 81); | ||
| auto check2 = euclid_sub(128 * 12, 128 * 77); | ||
|
|
||
| writeln(check1,'\n',check2); |
There was a problem hiding this comment.
The only thing I would add (to keep it consistent with Leios's Julia code) would be to
have the print statements say:
writeln("Modulus-based euclidean algorithm result: ", check1);
writeln("Subtraction-based euclidean algorithm result: ", check2);
leios
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.